Try to use a custom verifier for TLS #6564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/tls
branch
from
001330e
to
574189a
Compare
charliermarsh
commented
Aug 24, 2024
| // If not, we use ring. | ||
| let provider = rustls::crypto::CryptoProvider::get_default() | ||
| .map(|arc| arc.clone()) | ||
| .unwrap(); |
There was a problem hiding this comment.
All the of above has to be vendored and kept in-sync with reqwest.
charliermarsh
commented
Aug 24, 2024
| // Finalize TLS config | ||
| // STOPSHIP(charlie): Add `SSL_CERT` thing, it's private though? Ugh. | ||
| let mut tls = config_builder.with_no_client_auth(); | ||
| tls.enable_sni = true; |
There was a problem hiding this comment.
Basically stuck here, we need to read SSL_CERT and add it to config_builder, but the APIs that reqwest uses aren't public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is one attempt to do what's described in #4944 (comment). I'm stuck though because there is no public API to add an
Identityto a client builder.