Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default value of python-preference in docs/reference/settings.md #5755

Merged

Conversation

FishAlchemist
Copy link
Contributor

@FishAlchemist FishAlchemist commented Aug 3, 2024

Summary

After referring to #5637 and doing additional testing.
The default value in a stable state seems more reasonable to be only-system. managed in preview.

cpython-3.11.9-windows-x86_64-none     C:\Users\name\AppData\Local\Programs\Python\Python311\python.exe

cpython-3.10.14-windows-x86_64-none    C:\Users\name\AppData\Roaming\uv\data\python\cpython-3.10.14-windows-x86_64-none\install\python.exe
cpython-3.10.11-windows-x86_64-none    C:\Users\name\AppData\Local\Programs\Python\Python310\python.exe

cpython-3.9.19-windows-x86_64-none     C:\Users\name\AppData\Roaming\uv\data\python\cpython-3.9.19-windows-x86_64-none\python.exe

test on uv 0.2.33 (build from https://github.com/astral-sh/uv/tree/257007ccaf0912a41dfe91b534527a7b1f54e19a)

Stable version

uv venv -p 3.10 is 3.10.11 (System Python)
uv venv -p 3.9 is No interpreter found(3.9.19 for managed Python)
uv venv -p 3.9 --python-preference only-system is No interpreter found(fail)
uv venv -p 3.9 --python-preference only-managed is 3.9.19(success)
Do not use managed Python, only use the system Python, so it can be determined as only-system.

Preview mode

Note: 3.10.14 is managed python, 3.10.11 is system python.
uv venv -p 3.11 --preview is 3.11.9 (System Python)
uv venv -p 3.10 --preview is 3.10.14
uv venv -p 3.10 --preview --python-preference only-managed is 3.10.14
uv venv -p 3.10 --preview --python-preference managed is 3.10.14
uv venv -p 3.10 --preview --python-preference system is 3.10.11
venv -p 3.10 --preview --python-preference only-system is 3.10.11
Prioritize the managed Python and then select the system Python, so it can be determined as managed.


fixed #5754

Test Plan

Run website in local.
image

@zanieb
Copy link
Member

zanieb commented Aug 3, 2024

Hey! This file is generated. I think you'd need to fix it in the definition itself?

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gotcha. Thanks!

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Aug 3, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) August 3, 2024 23:28
@charliermarsh charliermarsh merged commit 26b3bfb into astral-sh:main Aug 3, 2024
57 checks passed
@FishAlchemist FishAlchemist deleted the FishAlchemist-docs-patch branch August 10, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect default value for python-preference in docs/reference/settings.md
3 participants