Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit sync after uv add #5705

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Limit sync after uv add #5705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions crates/uv/src/commands/project/add.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,10 +348,24 @@ pub(crate) async fn add(
}
}

// Perform a full sync, because we don't know what exactly is affected by the removal.
// TODO(ibraheem): Should we accept CLI overrides for this? Should we even sync here?
let extras = ExtrasSpecification::All;
let dev = true;
// Sync the environment.
let (extras, dev) = match dependency_type {
DependencyType::Production => {
let extras = ExtrasSpecification::None;
let dev = false;
(extras, dev)
}
DependencyType::Dev => {
let extras = ExtrasSpecification::None;
let dev = true;
(extras, dev)
}
DependencyType::Optional(ref group_name) => {
let extras = ExtrasSpecification::Some(vec![group_name.clone()]);
let dev = false;
(extras, dev)
}
};

project::sync::do_sync(
&VirtualProject::Project(project),
Expand Down
Loading