Set lower bounds in uv add
#5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
enhancement
charliermarsh
commented
Aug 1, 2024
| // If any of the requirements were added without version specifiers, add a lower bound. | ||
| let mut modified = false; | ||
| for edit in &edits { | ||
| // Only set a minimum version for newly-added dependencies (as opposed to updates). |
There was a problem hiding this comment.
Worth reviewing the criteria here for when we set a lower bound: (1) never for existing dependencies, it must be a new dependency in uv add; (2) never when the user provides a URL.
charliermarsh
force-pushed
the
charlie/add-lower-bound
branch
from
a3ad8e2
to
7f460bb
Compare
ibraheemdev
approved these changes
Aug 1, 2024
| @@ -154,24 +155,31 @@ pub(crate) async fn add( | |||
| .resolve() | |||
| .await?; | |||
|
|
|||
| // TODO(charlie): This should return an edit whereby it tells us which requirements were added | |||
charliermarsh
force-pushed
the
charlie/add-lower-bound
branch
from
7f460bb
to
45a83c2
Compare
charliermarsh
force-pushed
the
charlie/add-lower-bound
branch
from
45a83c2
to
e3606ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5178.