Fix non-registry serialization for receipts #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Jul 31, 2024
charliermarsh
force-pushed
the
charlie/ser
branch
from
7e1c6a5
to
29340cc
Compare
zanieb
approved these changes
Jul 31, 2024
charliermarsh
force-pushed
the
charlie/ser
branch
from
29340cc
to
f8a46bf
Compare
charliermarsh
force-pushed
the
charlie/ser
branch
2 times, most recently
from
6bafba7
to
6460bf0
Compare
charliermarsh
force-pushed
the
charlie/ser
branch
from
6460bf0
to
414246d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in #5494. The
RequirementSourceWirerepresentation was ambiguous, and so the order of the fields meant that all variants were mapped toRegistrywhen deserializing. (So the snapshots were right, but behaviors were wrong.)