Skip to content

Comments

Statically link liblzma#5577

Merged
charliermarsh merged 1 commit intomainfrom
charlie/xz2
Jul 29, 2024
Merged

Statically link liblzma#5577
charliermarsh merged 1 commit intomainfrom
charlie/xz2

Conversation

@charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jul 29, 2024

Summary

Found via indygreg/PyOxidizer#585.

Closes #5572.

@charliermarsh charliermarsh added the bug Something isn't working label Jul 29, 2024
@charliermarsh charliermarsh marked this pull request as ready for review July 29, 2024 21:31
@charliermarsh charliermarsh enabled auto-merge (squash) July 29, 2024 21:40
@charliermarsh charliermarsh merged commit ecb85c9 into main Jul 29, 2024
@charliermarsh charliermarsh deleted the charlie/xz2 branch July 29, 2024 21:46
lcheylus added a commit to jasperla/openbsd-wip that referenced this pull request Aug 20, 2024
- update Makefile, distinfo and crates.inc for version 0.2.37
- keep xz sources for lzma-sys crate to statically link liblzma
  See astral-sh/uv#5577

Signed-off-by: Laurent Cheylus <foxy@free.fr>
konstin added a commit that referenced this pull request May 2, 2025
#5577 fixed a bug on macos due to dynamically linking lzma/xz through static linking. In #7686, this feature was moved to the performance category.

This PR moves the `xz2/static` back to the general default features, and, inspired by Homebrew/homebrew-core#222211, it structures and documents the feature flags cleaner
zanieb added a commit that referenced this pull request May 2, 2025
#5577 fixed a bug on macos due to dynamically linking lzma/xz through
static linking. In #7686, this feature was moved to the performance
category.

This PR moves the `xz2/static` back to the general default features,
and, inspired by Homebrew/homebrew-core#222211,
it structures and documents the feature flags cleaner.

We need to take care that this feature does not accidentally disable
features we want.

---------

Co-authored-by: Zanie Blue <contact@zanie.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove dynamic linking to liblzma from pip binary

1 participant