Implement uv run --directory
#5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing for supporting this in uv run, update the .python-version reading functions so that they can read from more than just the current directory. Minor behaviour change(!). In some cases previously it could end up with different python versions depending on from which directory inside a wider workspace an operation was called from (if there were different .python-version files). I think this is clear from get_or_init_environment's use of discover.
charliermarsh
approved these changes
Jul 29, 2024
Allow running scripts and binaries from a project without changing directory to that project. Allow running scripts or binaries in a project without having to change directory into the project using uv run.
|
A test had to be fixed for windows but is now done. Edit - oh, needs preview label probably. |
charliermarsh
added
enhancement
charliermarsh
changed the title
uv run --directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
uv run --directory means that one doesn't have to change to a
project's directory to run programs from it. It makes it possible to use
projects as if they are tool installations.
To support this, first the code reading .python-version was updated so that
it can read such markers outside the current directory. Note the minor
change this causes (if I'm right), described in the commit.
Test Plan
One test has been added.
--directory
Not sure what the name of the argument should be, but it's following uv
sync's directory for now.
Other alternatives could be "--project". Uv run and uv tool run should
probably find common agreement on this (relevant for project-locked tools).
I've implemented this same change in Rye, some time ago, and then we went
with --pyproject
<path to pyproject.toml file>. I think usingpyproject.toml file path and not directory was probably a mistake, an
overgeneralization one doesn't need.