Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List installed tools when no command is provided to uv tool run #5553

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

eth3lbert
Copy link
Contributor

Summary

Part of #4024

Test Plan

Test cases included.

@eth3lbert
Copy link
Contributor Author

CI failures — seem unrelated to this change.

@T-256
Copy link
Contributor

T-256 commented Jul 29, 2024

From Charlie:

I think uv tool run should list the available executables, to start. That seems straightforward.

A tool can have multiple executables installed.

@eth3lbert
Copy link
Contributor Author

From Charlie:

I think uv tool run should list the available executables, to start. That seems straightforward.

A tool can have multiple executables installed.

Did I misunderstand the issue? I'm not sure I follow your point.

@T-256
Copy link
Contributor

T-256 commented Jul 29, 2024

Did I misunderstand the issue? I'm not sure I follow your point.

nvm, my bad. I didn't see the code and from title I thought it's going to list tool names only but not exposed entry points.

Comment on lines +805 to +809
----- stdout -----
black v24.2.0
- black
- blackd

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it also show a message about what the below list means:
Available tools and executables to run:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! However, since I'm simply reusing the tool_list, the output will exactly match uv run list. Additionally, if we want to display a message, we would probably expect the output of uv run list to change as well. I can make the change if desired, or perhaps it would be more suitable to make the change in a follow-up PR.

@charliermarsh charliermarsh enabled auto-merge (squash) July 29, 2024 22:03
@charliermarsh charliermarsh added cli Related to the command line interface preview Experimental behavior labels Jul 29, 2024
@charliermarsh charliermarsh merged commit 3e32902 into astral-sh:main Jul 29, 2024
57 checks passed
@eth3lbert eth3lbert deleted the tool-run-list-installed branch July 29, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants