Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check idempotence in packse lock scenarios #5485

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Jul 26, 2024

Add tests for the instabilities fix.

Part of #5180 (comment)

Closes #5180

@konstin konstin added the preview Experimental behavior label Jul 26, 2024
@konstin konstin force-pushed the konsti/merge-identical-resolutions branch from ff4651c to 6f29c03 Compare July 29, 2024 12:02
Copy link

codspeed-hq bot commented Jul 29, 2024

CodSpeed Performance Report

Merging #5485 will not alter performance

Comparing konsti/instability-tests (e40a5c4) with main (38c6033)

Summary

✅ 13 untouched benchmarks

@konstin konstin force-pushed the konsti/merge-identical-resolutions branch from 6f29c03 to 171dcb4 Compare July 29, 2024 12:18
@konstin konstin force-pushed the konsti/merge-identical-resolutions branch from 171dcb4 to a1e82fd Compare July 29, 2024 13:13
@konstin konstin force-pushed the konsti/instability-tests branch 2 times, most recently from d7e0d9b to ba88499 Compare July 29, 2024 13:25
@konstin konstin force-pushed the konsti/merge-identical-resolutions branch from a1e82fd to 662f87d Compare July 29, 2024 13:50
@konstin konstin added the bug Something isn't working label Jul 29, 2024
@konstin konstin force-pushed the konsti/merge-identical-resolutions branch from 662f87d to 100e160 Compare July 31, 2024 10:53
@konstin konstin force-pushed the konsti/instability-tests branch 2 times, most recently from f7dcc02 to c60e8ba Compare July 31, 2024 10:55
@konstin konstin marked this pull request as ready for review July 31, 2024 11:24
@konstin konstin requested a review from BurntSushi July 31, 2024 11:24
@konstin konstin force-pushed the konsti/merge-identical-resolutions branch from b0e3552 to 87ead41 Compare July 31, 2024 15:09
Base automatically changed from konsti/merge-identical-resolutions to main July 31, 2024 15:18
Add tests for the instabilities fix

Part of #5180 (comment)
@konstin konstin enabled auto-merge (squash) July 31, 2024 15:25
@konstin konstin disabled auto-merge July 31, 2024 15:26
@konstin konstin enabled auto-merge (squash) July 31, 2024 15:26
@konstin konstin merged commit 2247b0f into main Jul 31, 2024
57 checks passed
@konstin konstin deleted the konsti/instability-tests branch July 31, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instability with preferences and forks: Lockfile changes on the second run
3 participants