-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forks to lockfile, don't read them yet #5480
Conversation
8aff9ae
to
f521fdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all LGTM. I'll mourn the lock file's simplicity. Markers are everywhere!
Thinking about this a bit more, how does this interact with |
Yes, Example: Packse scenario "preferences-dependent-forking": First pass of
Second pass of
|
Add the overall list of forks to the lockfiles, so we can use them as preferences to avoid instabilities in the next step. I've ordered the structs so that metadata is on top, and payload at the bottom, as it is in the lockfile itself.
To set the preferences correctly, we need to know which version belongs to which fork. Instead of tracing that through the graph, we save this information in the lockfile to indicate to the user how and why there are multiple version for a package.
This gives the resolver access to the fork preferences from the lockfile.
f521fdf
to
4b1ca1f
Compare
Add the forks to the lockfile, without using them yet, which we'll add in the next PR.
Please review commit-by-commit
Part of #5180 (comment)