Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rust 1.80.0 #5472

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Upgrade to Rust 1.80.0 #5472

merged 1 commit into from
Jul 27, 2024

Conversation

charliermarsh
Copy link
Member

No description provided.

@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Jul 26, 2024
@@ -204,15 +204,17 @@ impl Interpreter {

/// Returns the [`Tags`] for this Python executable.
pub fn tags(&self) -> Result<&Tags, TagsError> {
self.tags.get_or_try_init(|| {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't stable, unfortunately, so it's manually implemented below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some day rust-lang/rust#109737 🙏

@charliermarsh charliermarsh force-pushed the charlie/rust branch 2 times, most recently from 8c5708b to 50fe323 Compare July 26, 2024 13:42
@charliermarsh charliermarsh force-pushed the charlie/rust branch 2 times, most recently from a418759 to 4b64b53 Compare July 26, 2024 18:31
@charliermarsh charliermarsh enabled auto-merge (squash) July 26, 2024 18:31
@samypr100
Copy link
Contributor

samypr100 commented Jul 27, 2024

re: CI / check windows trampoline | x86_64 (pull_request seems to be missing this lockfile update

crates/uv-trampoline/Cargo.lock from #5473

Copy link

codspeed-hq bot commented Jul 27, 2024

CodSpeed Performance Report

Merging #5472 will degrade performances by 11.11%

Comparing charlie/rust (4331aad) with main (3ea5e16)

Summary

❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main charlie/rust Change
wheelname_tag_compatibility[flyte-long-incompatible] 1.4 µs 1.6 µs -11.11%

@charliermarsh charliermarsh merged commit 24859bd into main Jul 27, 2024
54 of 55 checks passed
@charliermarsh charliermarsh deleted the charlie/rust branch July 27, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants