Add --no-workspace and --no-project in lieu of --isolated
#5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
cli
konstin
approved these changes
Jul 26, 2024
charliermarsh
force-pushed
the
charlie/no-project
branch
3 times, most recently
from
678c065
to
9910684
Compare
charliermarsh
changed the title
--no-workspace in lieu of --isolated--no-workspace and --no-project in lieu of --isolated
charliermarsh
changed the title
--no-workspace and --no-project in lieu of --isolated--no-workspace in lieu of --isolated
charliermarsh
force-pushed
the
charlie/no-project
branch
from
9910684
to
4f73389
Compare
charliermarsh
changed the title
--no-workspace in lieu of --isolated--no-workspace and --no-project in lieu of --isolated
charliermarsh
force-pushed
the
charlie/no-project
branch
from
4f73389
to
7110467
Compare
zanieb
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now,
--isolatedis read fromuv runanduv initto avoid discovering the current workspace (or project). This PR moves that behavior to a dedicated--no-workspaceflag foruv init, and--no-projectforuv run. They could use the same flag, but--no-projectfeels confusing foruv init, and--no-workspaceseems confusing foruv run(especially so once you read the documentation, where we refer to the thing you're omitting as the project).Closes #5429.