Allow distributions to be absent in deserialization #5453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Jul 25, 2024
|
|
||
| ----- stderr ----- | ||
| warning: `uv sync` is experimental and may change without warning | ||
| warning: No `requires-python` value found in the workspace. Defaulting to `>=3.12`. |
There was a problem hiding this comment.
Maybe we should throw a requires-python in there to reduce the noise?
There was a problem hiding this comment.
Not sure if we "can" since it's a virtual workspace (not a project). I'll try.
There was a problem hiding this comment.
Typically it would have at least one member.
There was a problem hiding this comment.
Yeah as soon as we add a project field it becomes non-virtual and the package itself gets included in the lockfile (making it non-empty).
zanieb
approved these changes
Jul 25, 2024
charliermarsh
force-pushed
the
charlie/empty
branch
from
e2cf605
to
58ed6ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5434.