Avoid canonicalizing executables on Windows #5446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/unc
branch
from
a337e26
to
004d672
Compare
charliermarsh
force-pushed
the
charlie/unc
branch
2 times, most recently
from
809d7ec
to
f685137
Compare
charliermarsh
changed the title
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/unc
branch
from
f685137
to
ee1e20c
Compare
|
Verified ee1e20c solves issue for me. |
|
Let's give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you have an executable path on a network share path (like
\\some-host\some-share\...\python.exe), canonicalizing it adds the\\?prefix, but dunce cannot safely strip it.This PR changes the Windows logic to avoid canonicalizing altogether. We don't really expect symlinks on Windows, so it seems unimportant to resolve them.
Closes: #5440.