Update to packse 0.3.31 #5441
Merged
Update to packse 0.3.31 #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
commented
Jul 25, 2024
Comment on lines
+2340
to
+2353
| /// Like `preferences-dependent-forking`, but when we don't fork the resolution | ||
| /// fails. Consider a fresh run without preferences: * We start with cleaver 2 * We | ||
| /// fork * We reject cleaver 2 * We find cleaver solution in fork 1 with foo 2 with | ||
| /// bar 1 * We find cleaver solution in fork 2 with foo 1 with bar 2 * We write | ||
| /// cleaver 1, foo 1, foo 2, bar 1 and bar 2 to the lockfile In a subsequent run, | ||
| /// we read the preference cleaver 1 from the lockfile (the preferences for foo and | ||
| /// bar don't matter): * We start with cleaver 1 * We're in universal mode, cleaver | ||
| /// requires foo 1, bar 1 * foo 1 requires bar 2, conflict Design sketch: ```text | ||
| /// root -> clear, foo, bar # Cause a fork, then forget that version. cleaver 2 -> | ||
| /// unrelated-dep==1; fork==1 cleaver 2 -> unrelated-dep==2; fork==2 cleaver 2 -> | ||
| /// reject-cleaver-2 # Allow different versions when forking, but force foo 1, bar 1 | ||
| /// in universal mode without forking. cleaver 1 -> foo==1; fork==1 cleaver 1 -> | ||
| /// bar==1; fork==2 # When we selected foo 1, bar 1 in universal mode for cleaver, | ||
| /// this causes a conflict, otherwise we select bar 2. foo 1 -> bar==2 ``` |
There was a problem hiding this comment.
@zanieb Should it be collapsing the markdown?
There was a problem hiding this comment.
Seems less than ideal. It seems fine to leave it on multiple lines? I'm not sure why this is happening.
konstin
force-pushed
the
konsti/packse-0-3-31
branch
from
537f206
to
835f16a
Compare
konstin
added a commit
to konstin/packse
that referenced
this pull request
Jul 26, 2024
Unlike json scenarios, toml and yaml scenarios have multi-line description fields, in which we can write proper markdown. Textwrap doesn't understand markdown and mangles it. To fix astral-sh/uv#5441 (comment), we stop textwrapping toml and yaml files. I've tested this locally and the snapshots look better, due to astral-sh/uv#5475 is somewhat incomplete though: astral-sh/uv#5441.
konstin
force-pushed
the
konsti/packse-0-3-31
branch
from
835f16a
to
ff6d3ec
Compare
konstin
force-pushed
the
konsti/packse-0-3-31
branch
from
ff6d3ec
to
68d5d05
Compare
|
I'm going ahead with this to unblock using these tests for #5180. We can fix the comments in a later update. |
konstin
added a commit
to konstin/packse
that referenced
this pull request
Aug 6, 2024
Unlike json scenarios, toml and yaml scenarios have multi-line description fields, in which we can write proper markdown. Textwrap doesn't understand markdown and mangles it. To fix astral-sh/uv#5441 (comment), we stop textwrapping toml and yaml files. I've tested this locally and the snapshots look better, due to astral-sh/uv#5475 is somewhat incomplete though: astral-sh/uv#5441.
konstin
added a commit
to astral-sh/packse
that referenced
this pull request
Aug 6, 2024
Unlike json scenarios, toml and yaml scenarios have multi-line description fields, in which we can write proper markdown. Textwrap doesn't understand markdown and mangles it. To fix astral-sh/uv#5441 (comment), we stop textwrapping toml and yaml files. I've tested this locally and the snapshots look better, due to astral-sh/uv#5475 is somewhat incomplete though: astral-sh/uv#5441.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update packse to 0.3.31, adding the instability scenarios.