Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logo in documentation #5421

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Use logo in documentation #5421

merged 1 commit into from
Jul 24, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jul 24, 2024 •
edited
Loading

Before
Screenshot 2024-07-24 at 3 12 28 PM

After
Screenshot 2024-07-24 at 3 11 07 PM

Alternatively
Screenshot 2024-07-24 at 3 10 45 PM

@zanieb zanieb added documentation Improvements or additions to documentation preview Experimental behavior labels Jul 24, 2024
@zanieb
Copy link
Member Author

zanieb commented Jul 24, 2024 •
edited
Loading

Honestly not in love with the look, seems like it'd need a tweak to the size.

Moving from 1.2 -> 1.0 rem

Screenshot 2024-07-24 at 3 14 30 PM

@zanieb zanieb marked this pull request as ready for review July 24, 2024 20:28
charliermarsh
charliermarsh approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I prefer uv logo to Astral logo. Would be nice to add more Astral to the footer if possible but not sure.

@zanieb
Copy link
Member Author

zanieb commented Jul 24, 2024

Think I should shrink it a little as in the later comment?

@charliermarsh
Copy link
Member

I slightly prefer the larger version but I'm fine with either.

@zanieb
Copy link
Member Author

zanieb commented Jul 24, 2024

Note we use the lightning bolt logo in Ruff (which looks pretty nice).

@zanieb zanieb merged commit ac81036 into main Jul 24, 2024
45 checks passed
@zanieb zanieb deleted the zb/docs-logo branch July 24, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

@MichaReiser MichaReiser Awaiting requested review from MichaReiser

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation preview Experimental behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @charliermarsh