Ignore Ctrl-C signals in uv run and uv tool run
#5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
bug
charliermarsh
force-pushed
the
charlie/sig
branch
from
0cc8848
to
9eb0929
Compare
konstin
approved these changes
Jul 24, 2024
|
Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a bit simpler than #5333, but seems to work in my testing on macOS and Windows. It's based on implementations that I found in Pixi and Wasmer.
Closes #5257.
Test Plan
On both macOS and Windows:
cargo run -- tool run --from jupyterlab jupyter-lab-- hit Ctrl-C; verify that the process exits and the terminal is left in a good state.cargo run -- run python-- hit Ctrl-C; verify that the process does not exit, but does on Ctrl-D.