Add --ci mode to uv cache prune
#5391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/extract
branch
from
b758cbc
to
d0108ea
Compare
charliermarsh
added
enhancement
charliermarsh
force-pushed
the
charlie/extract
branch
3 times, most recently
from
c912530
to
149fb26
Compare
charliermarsh
commented
Jul 24, 2024
| remove_dir(path)?; | ||
| } else { | ||
| remove_file(path)?; | ||
| } |
There was a problem hiding this comment.
This is a bug. We have handling for this below (for entries), but not for the top-level thing we passed to rm_rf.
konstin
approved these changes
Jul 24, 2024
crates/uv-cli/src/lib.rs
Outdated
| /// cache may have a negative impact on cache performance. Pruning unzipped wheels will leave | ||
| /// the cache with any built wheels in their zipped form. | ||
| #[arg(long)] | ||
| pub all_unzipped: bool, |
There was a problem hiding this comment.
What about calling it --ci and documenting it as keeping only the artifacts you want to upload to the CI cache?
There was a problem hiding this comment.
From a user perspective, I do feel this would be the main use-case. It would also make it immediately clear to me that I probably should use this in CI pipelines.
charliermarsh
changed the title
--all-unzipped to uv cache prune--ci mode to uv cache prune
charliermarsh
force-pushed
the
charlie/extract
branch
from
149fb26
to
50ba902
Compare
charliermarsh
force-pushed
the
charlie/extract
branch
from
50ba902
to
7ba49f2
Compare
|
Would you be interested in adding documentation for this to:
It could be brief. |
|
Yeah I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users can now run
uv cache prune --ci(open to feedback on the name of that flag) to remove all pre-built wheels from the cache, leaving behind zipped, built wheels (which tend to be the most expensive assets to re-create). This should greatly increase cache performance in CI environments, since uploading unzipped wheels can actually hurt performance if you're persisting the uv cache.Closes #5282.