Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPy finder #5337

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Add PyPy finder #5337

merged 4 commits into from
Jul 23, 2024

Conversation

j178
Copy link
Contributor

@j178 j178 commented Jul 23, 2024

Summary

This PR adds PyPy finder and adds PyPy to uv managed Python versions.

Test Plan

$ cargo run -- python install

.python-versions Outdated Show resolved Hide resolved
@zanieb
Copy link
Member

zanieb commented Jul 23, 2024

Awesome!

@zanieb zanieb self-assigned this Jul 23, 2024
@j178 j178 force-pushed the pypy-finder branch 2 times, most recently from 90f5f39 to 0eba332 Compare July 23, 2024 16:25
- `<implementation><version-specifier>` e.g. `cpython>=3.12,<3.13`
- `<implementation>-<version>-<os>-<arch>-<libc>` e.g. `cpython-3.12.3-macos-aarch64-none`

At this time, only CPython downloads are supported. However, PyPy support is planned.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would note something like "uv supports managed CPython and PyPy versions"

Copy link
Member

@zanieb zanieb Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should note this elsewhere... like in the installs section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added uv bundles a list of downloadable CPython and PyPy distributions for macOS, Linux, and Windows. in Installing a Python version section, what do you think?

docs/python-versions.md Outdated Show resolved Hide resolved
j178 added 4 commits July 24, 2024 00:52
# Conflicts:
#	crates/uv-python/fetch-download-metadata.py
#	docs/preview/toolchains.md
@j178 j178 marked this pull request as ready for review July 23, 2024 17:26
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Nice work.

@zanieb zanieb merged commit 7ddf67a into astral-sh:main Jul 23, 2024
54 of 55 checks passed
@zanieb zanieb added enhancement New feature or request preview Experimental behavior pypy Related to PyPy support labels Jul 23, 2024
@j178 j178 deleted the pypy-finder branch July 23, 2024 23:47
zanieb added a commit that referenced this pull request Jul 24, 2024
## Summary

After #5337, `fetch-download-metadata.py` fetches not just from
`python-build-standalone`, so updates the workflow to
`sync-python-releases.yml`.

Also includes `crates/uv-python/download-metadata.json` in `add-paths`.

---------

Co-authored-by: Zanie Blue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preview Experimental behavior pypy Related to PyPy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants