Remove trailing period from user-facing messages #5218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do people like this? |
|
I like consistency. I'm not sure I have a strong preference here yet, I'm curious to see if it feels different? |
|
The preview warnings sure stuck out before though |
|
Alright let's roll with it. |
|
Updating the test fixtures now which is a bit of a pain :) |
charliermarsh
force-pushed
the
charlie/per
branch
from
5af1eb5
to
b621278
Compare
charliermarsh
force-pushed
the
charlie/per
branch
from
b621278
to
21a1c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per #5209, we only show periods in messages when the message itself spans more than a single sentence.