Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color to python pin CLI #5215

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Add color to python pin CLI #5215

merged 1 commit into from
Jul 19, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Screenshot 2024-07-19 at 9 03 10 AM

@charliermarsh charliermarsh added the cli Related to the command line interface label Jul 19, 2024
@charliermarsh charliermarsh added the preview Experimental behavior label Jul 19, 2024
@charliermarsh charliermarsh marked this pull request as ready for review July 19, 2024 13:03
writeln!(printer.stdout(), "Pinned to `{output}`")?;
writeln!(
printer.stdout(),
"Pinned `{}` to `{}`",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like or dislike the choice to use .python-version in the message?

Screenshot 2024-07-19 at 12 41 50 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems nice, I think, for when we add #4970.

@charliermarsh charliermarsh requested review from zanieb and removed request for zanieb July 19, 2024 16:42
@charliermarsh charliermarsh merged commit 7762d78 into main Jul 19, 2024
54 checks passed
@charliermarsh charliermarsh deleted the charlie/pin branch July 19, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants