Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(settings): bunch of fixes and improvements #5177

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

mkniewallner
Copy link
Contributor

Summary

Spotted some issues in the settings documentation, and room for small improvements by linking to PEPs/RFCs.

Also updating contribution documentation to mention that it's necessary to enable the virtual environment before running mkdocs serve.

Test Plan

Running documentation locally.

@mkniewallner mkniewallner marked this pull request as ready for review July 18, 2024 04:01
Copy link

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good other than a small thing I noticed

# On Windows.
.venv\Scripts\activate
```

1. Run the development server with:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bullet point numbers below this are now off

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In markdown, it doesn't matter which number you use for ordered lists, as using "1" for multiple consecutive items will still generate a numerically ordered list: https://www.markdownguide.org/basic-syntax/#ordered-lists

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, didn't know about that feature!

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@charliermarsh charliermarsh merged commit f2e2825 into astral-sh:main Jul 19, 2024
51 of 52 checks passed
@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jul 19, 2024
@mkniewallner mkniewallner deleted the docs/improve-settings branch July 19, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants