Fix substring marker expression disjointness checks #4998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
added
bug
charliermarsh
approved these changes
Jul 12, 2024
crates/uv-resolver/src/marker.rs
Outdated
| @@ -49,7 +49,46 @@ pub(crate) fn is_disjoint(first: &MarkerTree, second: &MarkerTree) -> bool { | |||
| fn string_is_disjoint(this: &MarkerExpression, other: &MarkerExpression) -> bool { | |||
| use MarkerOperator::*; | |||
|
|
|||
| let (key, operator, value) = extract_string_expression(this).unwrap(); | |||
| // The `in` and `not in` operators are not reversible, so we have to ensure the expressions match exactly. | |||
There was a problem hiding this comment.
Can you include an example here, as you did in the PR summary?
konstin
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Noticed a bug here,
'a' in envandenv not in 'a'are not disjoint givenenv == 'ab'.