Add a command to append uv's binary directory to PATH #4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
enhancement
charliermarsh
commented
Jul 10, 2024
| @@ -86,6 +86,7 @@ fs2 = { version = "0.4.3" } | |||
| futures = { version = "0.3.30" } | |||
| glob = { version = "0.3.1" } | |||
| hex = { version = "0.4.3" } | |||
| home = { version = "0.5.9" } | |||
There was a problem hiding this comment.
(Already in our dependency tree.)
charliermarsh
force-pushed
the
charlie/ensure
branch
2 times, most recently
from
30a8816
to
df914fe
Compare
charliermarsh
commented
Jul 10, 2024
crates/uv-cli/src/lib.rs
Outdated
| @@ -2037,6 +2037,8 @@ pub enum ToolCommand { | |||
| List(ToolListArgs), | |||
| /// Uninstall a tool. | |||
| Uninstall(ToolUninstallArgs), | |||
| /// Ensure that the tool executable directory is on `PATH`. | |||
| Ensurepath, | |||
There was a problem hiding this comment.
I don't feel strongly about this being the name of the command.
zanieb
reviewed
Jul 10, 2024
zanieb
reviewed
Jul 10, 2024
Comment on lines
47
to
51
| // Prepare the command (e.g., `export PATH="$HOME/.cargo/bin:$PATH"`). | ||
| let Some(command) = shell.prepend_path(&executable_directory) else { | ||
| return Err(anyhow::anyhow!("The executable directory {} is not in PATH, but the necessary command to update {shell} could not be determined.", executable_directory.simplified_display().cyan())); | ||
| }; |
There was a problem hiding this comment.
There's also the rustup pattern of a ~/.cargo/env file e.g.
❯ cat ~/.cargo/env
#!/bin/sh
# rustup shell setup
# affix colons on either side of $PATH to simplify matching
case ":${PATH}:" in
*:"$HOME/.cargo/bin":*)
;;
*)
# Prepending path in case a system-installed rustc needs to be overridden
export PATH="$HOME/.cargo/bin:$PATH"
;;
esac
then we can suggest source and add that to the shell instead? Idk what the trade-offs are there.
There was a problem hiding this comment.
Yes I looked at that and the implementation, but I've never seen it before in other tools.
charliermarsh
force-pushed
the
charlie/ensure
branch
from
df914fe
to
e886356
Compare
|
I changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'll open follow-up tickets for Windows support.
Closes #4953.
Test Plan
Then:
Then:
Then: