Warn if tool binary directory is not on path #4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
error messages
charliermarsh
commented
Jul 10, 2024
| .unwrap() | ||
| )), | ||
| Some(Shell::Csh) => Some(format!( | ||
| "setenv PATH \"{}:$PATH\"", |
There was a problem hiding this comment.
Obviously not all tested, some ChatGPT help here...
charliermarsh
commented
Jul 10, 2024
| { | ||
| let export = match Shell::from_env() { | ||
| None => None, | ||
| Some(Shell::Nushell) => None, |
There was a problem hiding this comment.
Couldn't find a short invocation for this, it looks like you have to modify a file and source it.
charliermarsh
force-pushed
the
charlie/w
branch
2 times, most recently
from
7783255
to
ed9f6fe
Compare
konstin
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4671.
Test Plan