Respect requires-python when prefetching
#4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
bug
|
Will add test coverage. |
BurntSushi
approved these changes
Jul 8, 2024
|
As a side-note, are we tracking not hard-failing on errors during pre-fetch? Seems wild that this can crash the resolution. |
|
@zanieb - I don't think so... Part of the problem is that we do need to track failures here, we can't just skip silently, since if we later request the package and it fails in a way that we consider a hard failure (like a build failure), that does need to be surfaced. |
|
I created #4901. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is fallout from #4705. We need to respect
requires-pythonin the prefetch code to avoid building unsupported distributions.Closes #4898.