Add user-facing output to indicate PEP 723 script #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
cli
charliermarsh
force-pushed
the
charlie/pep
branch
from
87572cb
to
5f56b60
Compare
zanieb
reviewed
Jul 8, 2024
| debug!("Found PEP 723 script at: {}", target.display()); | ||
| writeln!( | ||
| printer.stderr(), | ||
| "Running PEP 723 script at: {}", |
There was a problem hiding this comment.
Can we refer to "inline script metadata" instead of the PEP? I think it'd be good to normalize the term and discuss things as the user-facing concept.
charliermarsh
force-pushed
the
charlie/pep
branch
from
5f56b60
to
9268ea6
Compare
zanieb
reviewed
Jul 8, 2024
| debug!("Found PEP 723 script at: {}", target.display()); | ||
| writeln!( | ||
| printer.stderr(), | ||
| "Reading inline script metadata from: {}", |
There was a problem hiding this comment.
A bit of a nit, but we've already read it right? And the user passed us this script name already? Should we just say "Using inline script metadata for requirements" (a little unsure about "requirements")
There was a problem hiding this comment.
I would prefer "Using inline script metadata for: {}"
zanieb
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.