Show user-facing warning when falling back to copy installs #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some valid use cases, mainly docker, where we expect the source and target to be on different file systems. We should add how to silence the warning ( |
konstin
approved these changes
Jul 8, 2024
|
I did have that initially but it felt a bit long and hard to explain. I'll add it back. |
charliermarsh
force-pushed
the
charlie/warn
branch
from
b311d6d
to
932a0e9
Compare
charliermarsh
commented
Jul 8, 2024
| @@ -5104,17 +5104,23 @@ fn target_no_build_isolation() -> Result<()> { | |||
|
|
|||
| /// Sync to a `--prefix` directory. | |||
| #[test] | |||
| #[cfg_attr( | |||
| windows, | |||
| ignore = "On macOS, we fail to reflink due to a non-existent site-packages directory" | |||
There was a problem hiding this comment.
This is an actual bug so fixing separately.
charliermarsh
force-pushed
the
charlie/warn
branch
from
932a0e9
to
523b990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This has come up a few times including in a recent email to me.