Add some decoration to tool CLI #4865
Conversation
charliermarsh
added
cli
| writeln!( | ||
| printer.stderr(), | ||
| "Uninstalled: {}", | ||
| "Uninstalled {} executable{s}: {}", |
There was a problem hiding this comment.
Are you opposed to using "executable" for user-facing copy?
There was a problem hiding this comment.
It feels a little weird, I don't have any great alternatives though. "tool entry points"? eh.
There was a problem hiding this comment.
We use tool entry points everywhere else in this output, right?
There was a problem hiding this comment.
But entry point is not as general... We also support data scripts which aren't entry points. I feel like entry point is sort of an implementation detail.
There was a problem hiding this comment.
Fair. Why not just "commands" then?
There was a problem hiding this comment.
I don't have strong feelings here.
There was a problem hiding this comment.
Cargo uses executable, e.g.
Replacing /Users/zb/.cargo/bin/cargo-nextest
Replaced package `cargo-nextest v0.9.70` with `cargo-nextest v0.9.72` (executable `cargo-nextest`)
There was a problem hiding this comment.
Ok, I'm gonna run with executable. I can change other user-facing copy too for consistency.
|
(I will update fixtures once approved, just a bit tedious.) |
| "Installing tool entry points into {}", | ||
| "Installing tool entrypoints into: {}", |
There was a problem hiding this comment.
These are always two words in the official documentation
https://packaging.python.org/en/latest/specifications/entry-points/
There was a problem hiding this comment.
(I like how entrypoints looks too, but I think we should be consistent. I've been following the official docs here)
There was a problem hiding this comment.
Oh strange, thank you, I can change it.
charliermarsh
force-pushed
the
charlie/tool-cli
branch
4 times, most recently
from
3db5614
to
7507786
Compare
charliermarsh
force-pushed
the
charlie/tool-cli
branch
from
7507786
to
58915da
Compare
Mostly small things. I added entrypoint counts and bolded the executable names.
Closes #4815.