Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use base interpreter for cached environments #4805

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Always use base interpreter for cached environments #4805

merged 1 commit into from
Jul 4, 2024

Conversation

charliermarsh
Copy link
Member

Closes #4801.

@charliermarsh charliermarsh added enhancement New feature or request preview Experimental behavior labels Jul 4, 2024
@charliermarsh charliermarsh force-pushed the charlie/cached branch 2 times, most recently from 8fe2dff to 04d6099 Compare July 4, 2024 14:55
zanieb
zanieb reviewed Jul 4, 2024
View reviewed changes
crates/uv/src/commands/project/environment.rs Outdated
Comment on lines 47 to 51
let interpreter = interpreter
.sys_base_executable()
.filter(|sys_base_executable| *sys_base_executable != interpreter.sys_executable())
.and_then(|sys_base_executable| Interpreter::query(sys_base_executable, cache).ok())
.map_or_else(
Copy link
Member

@zanieb zanieb Jul 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a Interpreter::into_base_intepreter(self) -> Interpreter method to do this? Seems like we'll want this other places.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing.

@charliermarsh charliermarsh enabled auto-merge (squash) July 4, 2024 17:32
@charliermarsh charliermarsh merged commit 445d45b into main Jul 4, 2024
47 checks passed
@charliermarsh charliermarsh deleted the charlie/cached branch July 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request preview Experimental behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cached environments should use base interpreter, if in a virtualenv
2 participants
@charliermarsh @zanieb