Fix implementation of GitDatabase::contains
#4698
Merged
+50
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
Jul 1, 2024
ibraheemdev
force-pushed
the
git-bug
branch
2 times, most recently
from
3b78ffb
to
2da9532
Compare
2 tasks
|
@ibraheemdev probably worth using a title that's more descriptive of the effect in the future so we don't need to go read the original issue to write the changelog entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GitDatabase::containspreviously only parsed the commit to see if it was a valid hash and didn't verify if the commit existed in the object database. This led to the database never being updated.Resolves #4378.
Test Plan
Added a test that fails without this change.