Respect data scripts in uv tool install
#4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have to identify a small package that does this for CI. |
charliermarsh
force-pushed
the
charlie/data
branch
from
da395ad
to
781ea4d
Compare
charliermarsh
force-pushed
the
charlie/data
branch
from
781ea4d
to
4da4065
Compare
konstin
approved these changes
Jul 1, 2024
|
It looks like |
|
Yeah, I think the benefit there is that it works even for packages that don't have a |
zanieb
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Packages that provide scripts that aren't Python entrypoints need to respected in
uv tool install. For example, Ruff ships a script inruff-0.5.0.data/scripts.Unfortunately, the
.datadirectory doesn't exist in the virtual environment at all (it's removed, per the spec, after install). So this PR changes the entry point detection to look at theRECORDfile, which is the only evidence that the scripts were installed.Closes #4691.
Test Plan
cargo run uv tool install ruff(snapshot tests to-come)