Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --universal and --python-platform mutually exclusive #4598

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jun 27, 2024

Summary

Open to just making this a warning but no strong opinion.

Closes #4593.

Test Plan

Failure:

❯ echo "pandas==2.2.2" | cargo run pip compile --universal -p 3.11 --no-header - --python-platform linux
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.15s
     Running `target/debug/uv pip compile --universal -p 3.11 --no-header - --python-platform linux`
error: the argument '--universal' cannot be used with '--python-platform <PYTHON_PLATFORM>'

Usage: uv pip compile --universal --python-version <PYTHON_VERSION> --no-header <SRC_FILE>...

For more information, try '--help'.

@charliermarsh charliermarsh added the cli Related to the command line interface label Jun 27, 2024
@charliermarsh charliermarsh changed the title Make --universal and --python-platform mutually exclusive Make --universal and --python-platform mutually exclusive Jun 27, 2024
@charliermarsh
Copy link
Member Author

I think I'll just make it a warning, shrug.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a warning, we ignore the python-platform entirely?

@charliermarsh
Copy link
Member Author

Yeah we ignore it either way.

@zanieb
Copy link
Member

zanieb commented Jun 27, 2024

Let's error then.

@charliermarsh
Copy link
Member Author

Ok, fine with me.

@charliermarsh charliermarsh merged commit 4c1181b into main Jun 27, 2024
47 checks passed
@charliermarsh charliermarsh deleted the charlie/plat branch June 27, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For uv pip compile how does the flag --universal interact with flags --python-version and --python-platform?
3 participants