Use "Prepared" instead of "Downloaded" in logs #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the "Downloading .." spinner text be changed too? |
|
Yep, did I miss one -.- |
zanieb
added a commit
that referenced
this pull request
Jun 18, 2024
Follow-up to #4394 with internal refactor
We download, build, and unzip packages in this stage. The current name is very misleading.
zanieb
force-pushed
the
zb/download-prepare
branch
from
8302386
to
b3f70a6
Compare
zanieb
added a commit
that referenced
this pull request
Jun 18, 2024
Follow-up to #4394 with internal refactor
ibraheemdev
approved these changes
Jun 18, 2024
zanieb
added a commit
that referenced
this pull request
Jun 18, 2024
Follow-up to #4394 with internal refactor
zanieb
added a commit
that referenced
this pull request
Jun 18, 2024
Follow-up to #4394 with internal refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We download, build, and unzip packages in this stage. The current name is very misleading.
Closes #4011