Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat mismatched directory and file urls as unsatisfied requirements #4393

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Treat mismatched directory and file urls as unsatisfied requirements #4393

merged 1 commit into from
Jun 19, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jun 18, 2024 •
edited
Loading

Closes #4391

@zanieb zanieb added the bug Something isn't working label Jun 18, 2024
@zanieb zanieb mentioned this pull request Jun 18, 2024
Closed
@zanieb zanieb requested a review from konstin June 18, 2024 18:07
@zanieb
Copy link
Member Author

zanieb commented Jun 18, 2024 •
edited
Loading

Since the tests passed, this really looks like an oversight. I'll look into adding a test case.

edit: Added in #4396 and rebased on top.

@zanieb zanieb mentioned this pull request Jun 18, 2024
Merged
@zanieb zanieb changed the base branch from main to zb/same-path June 18, 2024 18:36
@zanieb zanieb requested a review from BurntSushi June 18, 2024 21:00
charliermarsh
charliermarsh approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this got changed at some point during testing and never reverted? Thanks.

Base automatically changed from zb/same-path to main June 19, 2024 14:39
zanieb added a commit that referenced this pull request Jun 19, 2024
@zanieb
Add test case for wheel installation with different path (#4396)
549d7df 
Regression test for #4391 / #4393
@zanieb zanieb enabled auto-merge (squash) June 19, 2024 14:48
@zanieb zanieb merged commit 9a3b851 into main Jun 19, 2024
47 checks passed
@zanieb zanieb deleted the zb/mismatch-url branch June 19, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

@charliermarsh charliermarsh charliermarsh approved these changes

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uv pip install something.whl does not install the new version
4 participants
@zanieb @BurntSushi @charliermarsh @konstin