Support unnamed requirements in uv add
#4326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Jun 14, 2024
Comment on lines
+43
to
+44
| // Discover or create the virtual environment. | ||
| let venv = project::init_environment(project.workspace(), python.as_deref(), cache, printer)?; |
There was a problem hiding this comment.
Note we should only discover an interpreter not create an environment if syncing is disabled (looks like there's no toggle for that yet)
zanieb
reviewed
Jun 14, 2024
| resolution_environment(python_version, python_platform, venv.interpreter())?; | ||
|
|
||
| // Initialize the registry client. | ||
| let client = RegistryClientBuilder::new(cache.clone()) |
There was a problem hiding this comment.
Created #4330 to track the duplication of this after declaring a BaseClientBuilder above.
zanieb
reviewed
Jun 14, 2024
crates/uv/src/settings.rs
Outdated
| python, | ||
| } = args; | ||
|
|
||
| Self { | ||
| requirements, | ||
| python, | ||
| refresh: Refresh::from(refresh), | ||
| settings: ResolverSettings::combine(resolver_options(resolver, build), filesystem), |
There was a problem hiding this comment.
Since add performs a sync shouldn't it receive ResolverInstallerSettings?
There was a problem hiding this comment.
Partially unrelated to your work here. cc @charliermarsh
There was a problem hiding this comment.
Oh yes, I think it should.
zanieb
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support unnamed URL requirements in
uv add. For example,uv add git+https://github.com/pallets/flask.Part of #3959.