Apply system Python filtering to executable name requests #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
changed the title
zanieb
commented
Jun 13, 2024
zanieb
force-pushed
the
zb/executable-name-system
branch
from
46acca0
to
5162fcc
Compare
zanieb
changed the base branch from
zb/executable-name-find
to
zb/toolchain-refactor-system
BurntSushi
reviewed
Jun 13, 2024
BurntSushi
approved these changes
Jun 13, 2024
zanieb
force-pushed
the
zb/toolchain-refactor-system
branch
from
2e5e24e
to
c4432c5
Compare
zanieb
force-pushed
the
zb/executable-name-system
branch
from
5162fcc
to
49f8831
Compare
zanieb
force-pushed
the
zb/toolchain-refactor-system
branch
from
c4432c5
to
9602570
Compare
zanieb
force-pushed
the
zb/executable-name-system
branch
from
49f8831
to
b1197ce
Compare
zanieb
force-pushed
the
zb/executable-name-system
branch
from
b1197ce
to
dcb0f21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executable name requests were being treated as explicit requests to install into system environments, but I don't think it should be as it's implicit what environment you'll end up in. Following #4308, we allow multiple executables to be found so we can filter here.
Concretely, this means
--systemis required to install into a system environment discovered with e.g.--python=python. The flag is still not required for cases where we're not mutating environment.