Avoid treating direct path archives as always dynamic #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Jun 12, 2024
crates/uv-installer/src/satisfies.rs
Outdated
| if is_dynamic(requested_path) { | ||
| // TODO(charlie): Separate `RequirementSource` into `Path` and `Directory`. | ||
| if requested_path.is_dir() && is_dynamic(requested_path) { | ||
| trace!("Dynamic"); |
There was a problem hiding this comment.
Oh sorry I thought this was already present.
zanieb
approved these changes
Jun 12, 2024
charliermarsh
force-pushed
the
charlie/repeated
branch
from
77f7d1b
to
493d5bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now, we're always reinstalling local wheel archives, even if the timestamp didn't change.
I want to fix the TODO properly but I will do so in a separate PR.