Lock all packages in workspace #4016
Conversation
| ( | ||
| project_path.clone(), | ||
| ToolUvWorkspace::default(), | ||
| PyProjectToml::default(), |
There was a problem hiding this comment.
What's the motivation for this change? Why doesn't it return pyproject_toml?
There was a problem hiding this comment.
But what does it mean? What case is this?
There was a problem hiding this comment.
Oh you meant the branch not the line, this is for supporting implicit workspace roots, i've added a comment now.
|
I think we need to find some solution to |
konstin
force-pushed
the
konsti/lock-all-packages-in-workspace
branch
from
386d348
to
18d4528
Compare
|
I can either be the intersection or the union of the python requirement of the constituent packages. We could also force them to identical but that seems to strict. Let's say A has python >= 3.9 and B python >=3.10. From that, the union seems slightly better. |
|
Created #4041 that solves this properly |
When creating a lockfile, lock the combined dependencies for all packages in a workspace. This make the lockfile independent of where you are in the workspace. Fixes #3983
konstin
force-pushed
the
konsti/lock-all-packages-in-workspace
branch
from
4794cd6
to
bbfa5f4
Compare
|
I will review and merge today when I'm out of meetings. |
Follow-up to #4016. This exposes `Range` and `PubGrubSpecifier` from outside the resolver to use pubgrub's union creating a dependency edge we don't really want.
When creating a lockfile, lock the combined dependencies for all packages in a workspace. This make the lockfile independent of where you are in the workspace.
Fixes #3983