Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect resolved Git SHAs in uv lock #3956

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

This PR ensures that if a lockfile already contains a resolved reference (e.g., you locked with main previously, and it locked to a specific commit), and you run uv lock, we use the same SHA, even if it's not the latest SHA for that tag. This avoids upgrading Git dependencies without --upgrade.

Closes #3920.

@charliermarsh charliermarsh added enhancement New feature or request preview Experimental behavior labels Jun 1, 2024
@charliermarsh charliermarsh marked this pull request as ready for review June 1, 2024 12:22
Copy link

codspeed-hq bot commented Jun 1, 2024

CodSpeed Performance Report

Merging #3956 will improve performances by 6.27%

Comparing charlie/git-lock (bf529c1) with main (b7d77c0)

Summary

⚡ 1 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main charlie/git-lock Change
resolve_warm_jupyter 92.8 ms 87.3 ms +6.27%

@charliermarsh charliermarsh merged commit c04a95e into main Jun 1, 2024
46 checks passed
@charliermarsh charliermarsh deleted the charlie/git-lock branch June 1, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable preferences to respect Git checkouts
1 participant