-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: retag the musl aarch64 for manylinux2014 #3624
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
9a2f6f7
to
4dbf152
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do this with maturin build --target x86_64-unknown-linux-musl --compatibility 2_17 musllinux_1_1 [...]
in the maturin action step? This way maturin will enforce {many,musl}linux compliance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Should the original higher manylinux one be kept? Should this be done on other archs? |
For this PR, i'd keep the change small an only change this build. But in general: Yes please! A single manylinux + musllinux tagged build per arch would be great |
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Followup to #3624. Drops the native manylinux wheel in favor of the statically linked musl one with a manylinux2014 tag. <!-- How was it tested? --> Signed-off-by: Henry Schreiner <[email protected]>
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> <!-- What's the purpose of the change? What does it do, and why? --> Followup to #3624. Drops the native manylinux wheel in favor of the statically linked musl one with a manylinux2014 tag. <!-- How was it tested? --> Signed-off-by: Henry Schreiner <[email protected]>
Summary
Fix #3439 by retagging the statically linked musl binary for manylinux2014. This is the most conservative option;
the regular manylinux one could be removed as well, and I expect other archs could probably do this as well.
Test Plan
Testing on manylinux.