ci: retag the musl aarch64 for manylinux2014 #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/ci/muslarm
branch
from
9a2f6f7
to
4dbf152
Compare
henryiii
changed the title
konstin
requested changes
May 16, 2024
|
Should the original higher manylinux one be kept? Should this be done on other archs? |
|
For this PR, i'd keep the change small an only change this build. But in general: Yes please! A single manylinux + musllinux tagged build per arch would be great |
konstin
pushed a commit
that referenced
this pull request
May 21, 2024
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Followup to #3624. Drops the native manylinux wheel in favor of the statically linked musl one with a manylinux2014 tag. <!-- How was it tested? --> Signed-off-by: Henry Schreiner <[email protected]>
konstin
pushed a commit
that referenced
this pull request
May 21, 2024
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> <!-- What's the purpose of the change? What does it do, and why? --> Followup to #3624. Drops the native manylinux wheel in favor of the statically linked musl one with a manylinux2014 tag. <!-- How was it tested? --> Signed-off-by: Henry Schreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3439 by retagging the statically linked musl binary for manylinux2014. This is the most conservative option;
the regular manylinux one could be removed as well, and I expect other archs could probably do this as well.
Test Plan
Testing on manylinux.