Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect installed packages in uv run #3603

Merged
merged 1 commit into from
May 15, 2024
Merged

Respect installed packages in uv run #3603

merged 1 commit into from
May 15, 2024

Conversation

charliermarsh
Copy link
Member

Closes #3601.

@charliermarsh charliermarsh added bug Something isn't working preview Experimental behavior labels May 15, 2024
@charliermarsh charliermarsh marked this pull request as ready for review May 15, 2024 14:34
@charliermarsh charliermarsh requested a review from zanieb May 15, 2024 14:34
Comment on lines 44 to 45
// Determine the set of installed packages.
let site_packages = SitePackages::from_executable(&venv)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should locking prefer installed packages? We don't do this in pip compile.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@charliermarsh charliermarsh enabled auto-merge (squash) May 15, 2024 15:43
@charliermarsh charliermarsh merged commit ef068f1 into main May 15, 2024
44 checks passed
@charliermarsh charliermarsh deleted the charlie/inst branch May 15, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview Experimental behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv run can install two versions of the same package (and forces upgrades)
2 participants