Make cache clearing robust to directories without read permissions #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
May 11, 2024
| if set_readable(dir).unwrap_or(false) { | ||
| // Retry the operation; if we _just_ `self.rm_rf(dir)` and continue, | ||
| // `walkdir` may give us duplicate entries for the directory. | ||
| return self.rm_rf(path); |
There was a problem hiding this comment.
This is interesting. As in like, the error will be reported again in the iterator?
charliermarsh
force-pushed
the
charlie/dir
branch
from
0cb856d
to
eb72bc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you run the script included in the linked issue, then
uv cache clean, we hit permissions errors on certain directories created bysetuptools. The permissions on those directories look like:This PR adds logic to make those directories readable by the current user.
Closes #3515.