Change error value detection for glibc #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
May 9, 2024
| @@ -469,7 +469,7 @@ def get_operating_system_and_architecture(): | |||
| "major": musl_version[0], | |||
| "minor": musl_version[1], | |||
| } | |||
| elif glibc_version: | |||
| elif glibc_version != (-1, -1): | |||
There was a problem hiding this comment.
The return type of _get_glibc_version is tuple[int, int], not an optional.
There was a problem hiding this comment.
(I don't want to change _get_glibc_version since it's vendored.)
|
I don't know if this is helpful to you at all but in Hatch this is what we use to determine MUSL: https://github.com/pypa/hatch/blob/hatch-v1.10.0/src/hatch/python/resolve.py#L152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See: #3486. This just fixes the error message, not the underlying bug.