Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track origin for setup.py files and friends #3481

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented May 9, 2024

Summary

Ensures that we track the origins for requirements regardless of whether they come from pyproject.toml or setup.py or setup.cfg.

Closes #3480.

@charliermarsh charliermarsh added the enhancement New feature or request label May 9, 2024
@charliermarsh charliermarsh marked this pull request as draft May 9, 2024 05:05
@charliermarsh charliermarsh marked this pull request as ready for review May 9, 2024 05:11
@charliermarsh charliermarsh force-pushed the charlie/setup branch 3 times, most recently from 281ae21 to 93e05e4 Compare May 9, 2024 05:18
@@ -3919,7 +3927,7 @@ fn generate_hashes_local_directory() -> Result<()> {
--hash=sha256:c05567e9c24a6b9faaa835c4821bad0590fbb9d5779e7caa6e1cc4978e7eb24f
# via anyio
poetry-editable @ ../../scripts/packages/poetry_editable
# via [WORKSPACE]/scripts/packages/poetry_editable/pyproject.toml
# via -r [TEMP_DIR]/requirements.in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@charliermarsh charliermarsh merged commit 3e43653 into main May 9, 2024
43 checks passed
@charliermarsh charliermarsh deleted the charlie/setup branch May 9, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add # via source messages for setup.py and setup.cfg
2 participants