Filter irrelevant requirements from source annotations #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/filter
branch
from
4f6032b
to
e66ec64
Compare
charliermarsh
force-pushed
the
charlie/struct
branch
3 times, most recently
from
d20b2c5
to
6922b49
Compare
charliermarsh
force-pushed
the
charlie/filter
branch
from
e66ec64
to
05fe73a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a requirement is omitted due to a marker expression, we shouldn't include it as the "source" of a package in the output.
For example, if your constraints include
pathspec ; python_version < '3.12', and you're on Python 3.12, we should not include the constraint file as a "source" in the output annotations.