Improve JSON Schema and add export script #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/schema
branch
2 times, most recently
from
02db54f
to
a67079f
Compare
zanieb
reviewed
May 8, 2024
scripts/update_schemastore.py
Outdated
Comment on lines
18
to
19
| root = Path( | ||
| check_output(["git", "rev-parse", "--show-toplevel"], text=True).strip(), |
There was a problem hiding this comment.
Minor preference not to run a subprocess outside of main()
There was a problem hiding this comment.
(This is copied over from Ruff, but I shall change!)
charliermarsh
force-pushed
the
charlie/schema
branch
2 times, most recently
from
a0961d2
to
b3e2943
Compare
charliermarsh
force-pushed
the
charlie/schema
branch
from
b3e2943
to
0021e48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few errors I noticed after generating the schema.