Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UV_NO_BUILD_ISOLATION as environment variable #3318

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Add UV_NO_BUILD_ISOLATION as environment variable #3318

merged 3 commits into from
Apr 30, 2024

Conversation

flyaroundme
Copy link
Contributor

@flyaroundme flyaroundme commented Apr 30, 2024 •
edited
Loading

Summary

Hi! Added UV_NO_BUILD_ISOLATION as a boolean environment variable for the --no-build-isolation command-line option.

Closes #3309

Test Plan

Added new test respect_no_build_isolation_env_var to check that the behaviour is the same as if the --no-build-isolation command-line-option is set.

charliermarsh
charliermarsh approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks reasonable to me.

@charliermarsh charliermarsh added the configuration Settings and such label Apr 30, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) April 30, 2024 04:12
@charliermarsh charliermarsh merged commit f77583e into astral-sh:main Apr 30, 2024
29 checks passed
@zanieb
Copy link
Member

zanieb commented Apr 30, 2024

Should usage here be UV_BUILD_ISOLATION=false instead?

@BrewTestBot BrewTestBot mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
configuration Settings and such
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add environment variable for --no-build-isolation
3 participants
@flyaroundme @zanieb @charliermarsh