Unroll self-dependencies via extras #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
bug
charliermarsh
commented
Apr 24, 2024
|
|
||
| [project.optional-dependencies] | ||
| test = ["extras<0.0.2"] | ||
| coverage = ["example[test]", "extras>=0.0.1,<=0.0.2"] |
There was a problem hiding this comment.
This test fails if you try to build extras==0.0.2.
charliermarsh
force-pushed
the
charlie/priority
branch
from
8213a26
to
5653318
Compare
charliermarsh
force-pushed
the
charlie/priority
branch
from
5653318
to
503ee78
Compare
konstin
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We now recursively expand any self-dependencies via extras, which lets us detect conflicts sooner and avoid building unnecessary versions of packages that are excluded via the extra.
Closes #3135.