Avoid Removing Quotes From Requirement Markers #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
force-pushed
the
stray-quotes-fix
branch
from
2de0608
to
6601d52
Compare
ibraheemdev
force-pushed
the
stray-quotes-fix
branch
from
6601d52
to
7e83959
Compare
BurntSushi
approved these changes
Apr 23, 2024
|
(Gonna go out-of-turn and merge this here since it also includes fixes to get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid removing quotes from markers, e.g.
numpy (>=1.19) ; python_version >= "3.7"should not be rewritten. Fixes #2551.This PR also makes fixups a bit more flexible internally for fixes that aren't simple to implement with a pure regex replacement, like this one. #1529 fixed a similar problem but the current regex is still not smart enough to avoid all markers completely (like
python_version).Test Plan
Added a few unit tests.